Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 130963003: Android: moves remoting/ to use long for JNI. (Closed)

Created:
6 years, 11 months ago by bulach
Modified:
6 years, 11 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Android: moves remoting/ to use long for JNI. BUG=317523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244070

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/remoting_android.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bulach
ptal
6 years, 11 months ago (2014-01-09 12:34:42 UTC) #1
Lambros
lgtm
6 years, 11 months ago (2014-01-09 17:11:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/130963003/1
6 years, 11 months ago (2014-01-09 17:11:13 UTC) #3
commit-bot: I haz the power
Failed to apply patch for remoting/remoting.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-09 17:11:14 UTC) #4
Lambros
I've recently moved the Android targets into remoting/remoting_android.gypi - you'll have to rebase, sorry about ...
6 years, 11 months ago (2014-01-09 17:14:21 UTC) #5
bulach
ahn, no worries! rebased, CQing (same trivial change..)
6 years, 11 months ago (2014-01-09 19:49:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/130963003/80001
6 years, 11 months ago (2014-01-09 19:50:00 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 03:28:09 UTC) #8
Message was sent while issue was closed.
Change committed as 244070

Powered by Google App Engine
This is Rietveld 408576698