Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1309593003: Oilpan: fix build after r200992. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r200992. TBR=oilpan-reviews BUG=514651 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201005

Patch Set 1 #

Patch Set 2 : DocumentLoadTiming is a part object; adjust #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/core/dom/ScriptedIdleTaskController.h View 1 1 chunk +4 lines, -2 lines 1 comment Download
M Source/core/dom/ScriptedIdleTaskController.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sof
5 years, 4 months ago (2015-08-21 19:20:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309593003/20001
5 years, 4 months ago (2015-08-21 19:20:41 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201005
5 years, 4 months ago (2015-08-21 19:26:00 UTC) #4
rmcilroy
On 2015/08/21 19:26:00, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
5 years, 4 months ago (2015-08-21 20:24:11 UTC) #5
haraken
LGTM
5 years, 4 months ago (2015-08-22 00:00:06 UTC) #6
sof
5 years, 4 months ago (2015-08-22 05:39:49 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1309593003/diff/20001/Source/core/dom/Scripte...
File Source/core/dom/ScriptedIdleTaskController.h (right):

https://codereview.chromium.org/1309593003/diff/20001/Source/core/dom/Scripte...
Source/core/dom/ScriptedIdleTaskController.h:51: const DocumentLoadTiming&
m_timing;
This const reference to a part object (of a DocumentLoader) -- same for
IdleCallbackDeadline -- was left as-is, but is something that needs to be
addressed eventually.

Powered by Google App Engine
This is Rietveld 408576698