Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: runtime/vm/thread.cc

Issue 1309563004: On Windows, set current thread in TLS to NULL before deleting the thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.cc
diff --git a/runtime/vm/thread.cc b/runtime/vm/thread.cc
index 260f59088ae169ec397713235d46287c90f0e43b..18c062dc90744f19bc8473e7fce41b0e72626801 100644
--- a/runtime/vm/thread.cc
+++ b/runtime/vm/thread.cc
@@ -93,9 +93,9 @@ void Thread::EnsureInit() {
void Thread::CleanUp() {
Thread* current = Current();
if (current != NULL) {
+ SetCurrent(NULL);
delete current;
Ivan Posva 2015/08/21 03:23:56 Are we sure the destructor will not touch anything
koda 2015/08/21 17:15:42 I can't guarantee it won't, but if it did, we'd al
}
- SetCurrent(NULL);
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698