Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: src/gpu/GrDrawContext.cpp

Issue 1309543012: Add new GM to directly exercise perspective bitmap drawing (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add AA case Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gm/perspshaders.cpp ('K') | « gm/perspshaders.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDrawContext.cpp
diff --git a/src/gpu/GrDrawContext.cpp b/src/gpu/GrDrawContext.cpp
index b11518f018fe89d86444785b053291c6ebc1b7e3..3942647a7381ec6288d5e439642cf9c0f36f01a8 100644
--- a/src/gpu/GrDrawContext.cpp
+++ b/src/gpu/GrDrawContext.cpp
@@ -274,7 +274,6 @@ void GrDrawContext::drawRect(GrRenderTarget* rt,
// The fill path can handle rotation but not skew
// The stroke path needs the rect to remain axis aligned (no rotation or skew)
// None of our draw rect calls can handle perspective yet
- SkASSERT(!viewMatrix.hasPerspective());
joshualitt 2015/09/02 17:37:20 Could we move this to line 281? maybe its not nece
robertphillips 2015/09/03 15:25:31 Done.
bool canApplyAA = width >=0 ? viewMatrix.rectStaysRect() : viewMatrix.preservesRightAngles();
if (needAA && canApplyAA) {
« gm/perspshaders.cpp ('K') | « gm/perspshaders.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698