Add new GM to directly exercise perspective bitmap drawing

Add new GM to directly exercise perspective bitmap drawing

BUG=skia:3326
Committed: https://skia.googlesource.com/skia/+/fac9ceb5de5288fa9f98a6cf77085b37da601b36

[robertphillips, 2015-09-02 16:21:16]

robertphillips@google.com changed reviewers:
+ joshualitt@chromium.org

[joshualitt, 2015-09-02 17:37:19]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-09-02 17:37:20]

nits

https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp
File gm/perspshaders.cpp (right):

https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp#new...
gm/perspshaders.cpp:14: static SkImage* make_image(SkCanvas* origCanvas, int w,
int h) {
could we make these guys helpers in some way?

https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp#new...
gm/perspshaders.cpp:52: return SkISize::Make(kCellSize*6, kCellSize*5);
can these be constants as well?

https://codereview.chromium.org/1309543012/diff/20001/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (left):

https://codereview.chromium.org/1309543012/diff/20001/src/gpu/GrDrawContext.c...
src/gpu/GrDrawContext.cpp:277: SkASSERT(!viewMatrix.hasPerspective());
Could we move this to line 281? maybe its not necessary.

[robertphillips, 2015-09-03 15:25:08]

https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp
File gm/perspshaders.cpp (right):

https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp#new...
gm/perspshaders.cpp:14: static SkImage* make_image(SkCanvas* origCanvas, int w,
int h) {
On 2015/09/02 17:37:20, joshualitt wrote:
> could we make these guys helpers in some way?

Acknowledged. Will add in a separate patch.

https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp#new...
gm/perspshaders.cpp:52: return SkISize::Make(kCellSize*6, kCellSize*5);
On 2015/09/02 17:37:20, joshualitt wrote:
> can these be constants as well?

Done.

[joshualitt, 2015-09-03 15:25:26]

On 2015/09/03 15:25:08, robertphillips wrote:
> https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp
> File gm/perspshaders.cpp (right):
> 
>
https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp#new...
> gm/perspshaders.cpp:14: static SkImage* make_image(SkCanvas* origCanvas, int
w,
> int h) {
> On 2015/09/02 17:37:20, joshualitt wrote:
> > could we make these guys helpers in some way?
> 
> Acknowledged. Will add in a separate patch.
> 
>
https://codereview.chromium.org/1309543012/diff/20001/gm/perspshaders.cpp#new...
> gm/perspshaders.cpp:52: return SkISize::Make(kCellSize*6, kCellSize*5);
> On 2015/09/02 17:37:20, joshualitt wrote:
> > can these be constants as well?
> 
> Done.

lgtm

[robertphillips, 2015-09-03 15:25:32]

https://codereview.chromium.org/1309543012/diff/20001/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (left):

https://codereview.chromium.org/1309543012/diff/20001/src/gpu/GrDrawContext.c...
src/gpu/GrDrawContext.cpp:277: SkASSERT(!viewMatrix.hasPerspective());
On 2015/09/02 17:37:20, joshualitt wrote:
> Could we move this to line 281? maybe its not necessary.

Done.

[robertphillips, 2015-09-03 15:25:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 15:25:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309543012/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309543012/40001

[commit-bot: I haz the power, 2015-09-03 15:30:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 15:30:39]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-09-03 15:31:24]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-09-03 15:31:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309543012/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309543012/40001

[commit-bot: I haz the power, 2015-09-03 15:32:11]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/fac9ceb5de5288fa9f98a6cf77085b37da601b36