Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309533002: Merge a couple of memory cache hit notifications (Closed)

Created:
5 years, 4 months ago by Nate Chapin
Modified:
5 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Merge a couple of memory cache hit notifications Both dispatchDidLoadResourceFromMemoryCache() and sendRemainingDelegateMessages() are only called when a cache hit occurs. Combine their logic into dispatchDidLoadResourceFromMemoryCache(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201017

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -36 lines) Patch
M Source/core/fetch/FetchContext.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fetch/FetchContext.cpp View 1 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 chunks +2 lines, -15 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309533002/1
5 years, 4 months ago (2015-08-21 18:04:06 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59882) ios_rel_device_ninja on ...
5 years, 4 months ago (2015-08-21 18:05:24 UTC) #4
Nate Chapin
https://codereview.chromium.org/1309533002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (left): https://codereview.chromium.org/1309533002/diff/1/Source/core/fetch/ResourceFetcher.cpp#oldcode799 Source/core/fetch/ResourceFetcher.cpp:799: The logic below this point moved to FrameFetchContext.cpp
5 years, 4 months ago (2015-08-21 18:06:26 UTC) #6
Mike West
LGTM.
5 years, 4 months ago (2015-08-21 18:39:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309533002/20001
5 years, 4 months ago (2015-08-21 19:47:23 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 21:31:52 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201017

Powered by Google App Engine
This is Rietveld 408576698