Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1309523005: In generators, "yield" cannot be an arrow formal parameter name (Closed)

Created:
5 years, 4 months ago by wingo
Modified:
5 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev, conradw
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In generators, "yield" cannot be an arrow formal parameter name Thanks to André Bargull for the report. BUG=v8:4212 LOG=N R=rossberg@chromium.org Committed: https://crrev.com/e7cd9d3296e4cb6e11de9a1f3d351e9d4837b49e Cr-Commit-Position: refs/heads/master@{#30381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M src/preparser.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
wingo
5 years, 4 months ago (2015-08-26 10:26:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309523005/1
5 years, 4 months ago (2015-08-26 10:27:23 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-26 11:11:52 UTC) #5
rossberg
lgtm
5 years, 4 months ago (2015-08-26 11:49:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309523005/1
5 years, 3 months ago (2015-08-26 11:58:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 11:59:39 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 11:59:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7cd9d3296e4cb6e11de9a1f3d351e9d4837b49e
Cr-Commit-Position: refs/heads/master@{#30381}

Powered by Google App Engine
This is Rietveld 408576698