include/svg/parser/SkSVGAttribute.h - Issue 1309523003: Remove SK_OFFSETOF from SkTypes, clean up offsetof usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/svg/parser/SkSVGAttribute.h

Issue 1309523003: Remove SK_OFFSETOF from SkTypes, clean up offsetof usage. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Speling Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/svg/parser/SkSVGAttribute.h

diff --git a/include/svg/parser/SkSVGAttribute.h b/include/svg/parser/SkSVGAttribute.h

index 940ca5a951431169634a853e568f6907a519b5d4..5ba2916b742699cf1fc7d02284a3403e99e2c37d 100644

--- a/include/svg/parser/SkSVGAttribute.h

+++ b/include/svg/parser/SkSVGAttribute.h

@@ -20,7 +20,8 @@ struct SkSVGAttribute {

};

#ifndef SK_OFFSETOF

-#define SK_OFFSETOF(a, b) (((size_t) (&(((a*) 1)->b)))-1)

+ // This is offsetof for types which are not standard layout.

+ #define SK_OFFSETOF(type, field) (size_t)((char*)&(((type*)1024)->field) - (char*)1024)

#endif

#ifdef SK_DEBUG

« no previous file with comments | « include/private/SkTemplates.h ('k') | src/animator/SkDisplayInclude.cpp » ('j') | no next file with comments »