LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js - Issue 1309513008: [css-grid] Implement grid gutters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js

Issue 1309513008: [css-grid] Implement grid gutters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed two tests which were not testing gutters code Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html ('K') | « LayoutTests/fast/css-grid-layout/resources/grid-alignment.css ('k') | LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout.html » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js b/LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js

index 56e1fbd35a1ed1f2b1d231beee4e0e5875579159..4ebd88be0b5a8ffe894eac22b1dc952a95edb0de 100644

--- a/LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js

@@ -69,3 +69,9 @@ function testGridAutoDefinitionsValues(element, computedRowValue, computedColumn

shouldBeEqualToString("window.getComputedStyle(" + elementID + ", '').getPropertyValue('grid-auto-rows')", computedRowValue);

shouldBeEqualToString("window.getComputedStyle(" + elementID + ", '').getPropertyValue('grid-auto-columns')", computedColumnValue);

}

+function testGridGapDefinitionsValues(element, computedRowGap, computedColumnGap)

+ shouldBeEqualToString("window.getComputedStyle(" + element + ", '').getPropertyValue('grid-row-gap')", computedRowGap);

+ shouldBeEqualToString("window.getComputedStyle(" + element + ", '').getPropertyValue('grid-column-gap')", computedColumnGap);