Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Issue 1309513005: Revert of [simd.js] Update to spec version 0.8.2. (Closed)

Created:
5 years, 4 months ago by Michael Hablich
Modified:
5 years, 4 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [simd.js] Update to spec version 0.8.2. (patchset #11 id:200001 of https://codereview.chromium.org/1294513004/ ) Reason for revert: Fails tests: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20deadcode/builds/5073/steps/steps/logs/stdio Original issue's description: > [simd.js] Update to spec version 0.8.2. > > Adds Uint32x4, Uint16x8, and Uint8x16 types. > Adds all functions in the current spec, except for loads and stores. > > LOG=Y > BUG=v8:4124 > > Committed: https://crrev.com/4be6d37fd1ad0a6e0ea37da8863ae5169c2b89ba > Cr-Commit-Position: refs/heads/master@{#30322} TBR=littledan@chromium.org,bbudge@google.com,bmeurer@chromium.org,hpayer@chromium.org,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/86016622b4f20588f62401786c7534b532977d0b Cr-Commit-Position: refs/heads/master@{#30323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -912 lines) Patch
M src/contexts.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/harmony-simd.js View 29 chunks +175 lines, -379 lines 0 comments Download
M src/heap/heap.h View 3 chunks +0 lines, -12 lines 0 comments Download
M src/messages.js View 3 chunks +2 lines, -25 lines 0 comments Download
M src/objects.h View 3 chunks +0 lines, -9 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 8 chunks +19 lines, -129 lines 0 comments Download
M src/runtime/runtime-simd.cc View 18 chunks +78 lines, -218 lines 0 comments Download
M test/cctest/test-heap.cc View 7 chunks +15 lines, -56 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-simd.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/simd.js View 6 chunks +3 lines, -63 lines 0 comments Download
M test/simdjs/testcfg.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of [simd.js] Update to spec version 0.8.2.
5 years, 4 months ago (2015-08-24 10:06:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309513005/1
5 years, 4 months ago (2015-08-24 10:06:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 10:06:36 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 10:06:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86016622b4f20588f62401786c7534b532977d0b
Cr-Commit-Position: refs/heads/master@{#30323}

Powered by Google App Engine
This is Rietveld 408576698