Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309503004: Select elements should clear type-ahead session on blur. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, vivekg, dglazkov+blink, blink-reviews-html_chromium.org, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Select elements should clear type-ahead session on blur. Also, add Internals::resetTypeAheadSession(). These changes fix flakiness of fast/forms/select/select-typeahead-with-spacekey.html. TestExpectatios still has the flaky expectation for the test just in case. BUG=479202 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M LayoutTests/fast/forms/select/select-typeahead-with-spacekey.html View 3 chunks +11 lines, -19 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/html/forms/TypeAhead.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/forms/TypeAhead.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 3 months ago (2015-08-28 08:00:09 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-08-28 08:40:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309503004/1
5 years, 3 months ago (2015-08-28 09:03:36 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 09:08:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201385

Powered by Google App Engine
This is Rietveld 408576698