Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: docs/use_find_bugs_for_android.md

Issue 1309473002: WIP: Migrate Wiki content over to src/docs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « docs/updating_clang_format_binaries.md ('k') | docs/useful_urls.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Introduction
2
3 [FindBugs](http://findbugs.sourceforge.net) is an open source static analysis to ol from the University of Maryland that looks for potential bugs in Java class f iles. We have some scripts to run it over the Java code at build time.
4
5 # How To Run
6
7 For gyp builds, add `run_findbugs=1` to your `GYP_DEFINES`.
8
9 For gn builds, add `run_findbugs=true` to the args you pass to `gn gen`:
10
11 ```
12 gn gen --args='target_os="android" run_findbugs=true'
13 ```
14
15 Note that running findbugs will add time to your build. The amount of additional time required depends on the number of targets on which findbugs runs, though i t will usually be between 1-10 minutes.
16
17 Some of the warnings are false positives. In general, they should be suppressed using [@SuppressFBWarnings](https://code.google.com/p/chromium/codesearch#chromi um/src/base/android/java/src/org/chromium/base/annotations/SuppressFBWarnings.ja va). In the rare event that a warning should be suppressed across the entire cod e base, it should be added to the [exclusion file](https://code.google.com/p/chr omium/codesearch#chromium/src/build/android/findbugs_filter/findbugs_exclude.xml ) instead. If you modify this file:
18
19 * Include a comment that says what you're suppressing and why.
20 * The existing suppressions should give you an idea of the syntax. See also th e FindBugs documentation. Note that the documentation doesn't seem totally accur ate (there's probably some version skew between the online docs and the version of FindBugs we're using) so you may have to experiment a little.
21
22 # Chromium's [FindBugs](http://findbugs.sourceforge.net) plugin
23
24 We have [FindBugs plugin](https://code.google.com/p/chromium/codesearch#chromium /src/tools/android/findbugs_plugin/) to enforce chromium specific Java rules. It currently detects:
25 * Synchronized method
26 * Synchronized this
27
28 # [FindBugs](http://findbugs.sourceforge.net) on the Bots
29
30 [FindBugs](http://findbugs.sourceforge.net) is configured to run on:
31 * [android\_clang\_dbg\_recipe](http://build.chromium.org/p/tryserver.chromium .linux/builders/android_clang_dbg_recipe) on the commit queue
32 * [Android Clang Builder (dbg)](http://build.chromium.org/p/chromium.linux/bui lders/Android%20Clang%20Builder%20(dbg)) on the main waterfall
OLDNEW
« no previous file with comments | « docs/updating_clang_format_binaries.md ('k') | docs/useful_urls.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698