Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: Source/modules/compositorworker/CompositorWorker.cpp

Issue 1309463002: CompositorWorker is now always on the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/compositorworker/CompositorWorker.cpp
diff --git a/Source/modules/compositorworker/CompositorWorker.cpp b/Source/modules/compositorworker/CompositorWorker.cpp
index 3e30946021747aaa07e7ce3be9f0c39c18357109..3a1a92c029a35cff446f732911ba2581a50d6b5a 100644
--- a/Source/modules/compositorworker/CompositorWorker.cpp
+++ b/Source/modules/compositorworker/CompositorWorker.cpp
@@ -20,7 +20,7 @@ inline CompositorWorker::CompositorWorker(ExecutionContext* context)
{
}
-PassRefPtrWillBeRawPtr<CompositorWorker> CompositorWorker::create(ExecutionContext* context, const String& url, ExceptionState& exceptionState)
+CompositorWorker* CompositorWorker::create(ExecutionContext* context, const String& url, ExceptionState& exceptionState)
{
ASSERT(isMainThread());
Document* document = toDocument(context);
@@ -28,9 +28,9 @@ PassRefPtrWillBeRawPtr<CompositorWorker> CompositorWorker::create(ExecutionConte
exceptionState.throwDOMException(InvalidAccessError, "The context provided is invalid.");
return nullptr;
}
- RefPtrWillBeRawPtr<CompositorWorker> worker = adoptRefWillBeNoop(new CompositorWorker(context));
+ CompositorWorker* worker = new CompositorWorker(context);
if (worker->initialize(context, url, exceptionState))
- return worker.release();
+ return worker;
return nullptr;
}
« no previous file with comments | « Source/modules/compositorworker/CompositorWorker.h ('k') | Source/modules/compositorworker/CompositorWorker.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698