Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1309433002: Report better error message on update sandbox for gn builds (Closed)

Created:
5 years, 6 months ago by IrfanGoogle
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, miu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report better error message on update sandbox for gn builds The documentation for gn builds specifies using a different output directory than gyp builds, but the update sandbox script reports error message assuming only gyp builds. Update the error message to prod user into specifying BUILDTYPE to find the sandbox in the right place BUG= Committed: https://crrev.com/d8807ee10dd5e1e534e46311383c51cc56999f42 Cr-Commit-Position: refs/heads/master@{#344600}

Patch Set 1 #

Patch Set 2 : Add cast events to about:tracing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M build/update-linux-sandbox.sh View 1 chunk +3 lines, -2 lines 0 comments Download
M media/cast/sender/audio_encoder.cc View 1 4 chunks +11 lines, -0 lines 0 comments Download
M media/cast/sender/congestion_control.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 1 4 chunks +27 lines, -0 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 5 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
IrfanGoogle
On 2015/08/20 18:12:54, isheriff wrote: > mailto:isheriff@google.com changed reviewers: > + mailto:miu@chromium.org Mostly a starter ...
5 years, 6 months ago (2015-08-20 18:13:42 UTC) #2
IrfanGoogle
5 years, 6 months ago (2015-08-20 18:13:58 UTC) #3
miu
lgtm Added an OWNER for approval.
5 years, 6 months ago (2015-08-20 21:19:18 UTC) #5
Dirk Pranke
lgtm
5 years, 6 months ago (2015-08-20 21:32:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309433002/1
5 years, 6 months ago (2015-08-20 21:35:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-08-20 22:39:10 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-08-20 22:40:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8807ee10dd5e1e534e46311383c51cc56999f42
Cr-Commit-Position: refs/heads/master@{#344600}

Powered by Google App Engine
This is Rietveld 408576698