Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 130943004: Regularize extended attributes on partial interfaces (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, shans, Michael van Ouwerkerk, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, Steve Block, dino_apple.com, Nils Barth (inactive), Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, alecflett, dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, Eric Willigers, philipj_slow, rjwright, sof, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, kojih, jsbell, jsbell+bindings_chromium.org, Mike Lawther (Google), Inactive, cmumford, dgrogan, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Regularize extended attributes on partial interfaces This is cleanup CL, as part of implementing partial interfaces in the Python IDL compiler. Primarily it moves overall [RuntimeEnabled] extended attributes (and [Conditional] and [PerContextEnabled]) to the partial interface itself, rather than individual members, so: [   RuntimeEnabled=FeatureName, ] partial interface Foo {   void a();   void b(); }; instead of: partial interface Foo {   [RuntimeEnabled=FeatureName] void a();   [RuntimeEnabled=FeatureName] void b(); }; This is for consistency: these extended attributes can be applied to the partial interface itself, which means they are applied to all members, so we can switch it on or off with one line. Currently some IDL files put this on the partial interface, while others put it on all members; this makes it consistent and clarifies intent. (We could remove all of these, simplifying merging a bit, at the cost of putting these on all the individual member lines.) Docs: https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-Partial-interfaces No changes to generated code. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -175 lines) Patch
M Source/bindings/tests/idls/TestPartialInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/testing/SupportTestPartialInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 6 chunks +96 lines, -96 lines 0 comments Download
M Source/core/animation/ElementAnimation.idl View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/css/DocumentFontFaceSet.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.idl View 1 chunk +11 lines, -8 lines 0 comments Download
M Source/core/events/NavigatorEvents.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/page/WindowPagePopup.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/xml/DocumentXPathEvaluator.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/WindowCrypto.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/donottrack/NavigatorDoNotTrack.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DataTransferItemFileSystem.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/HTMLInputElementFileSystem.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/filesystem/WindowFileSystem.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/geolocation/NavigatorGeolocation.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/imagebitmap/WindowImageBitmapFactories.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/WindowIndexedDatabase.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/HTMLVideoElementMediaSource.idl View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/modules/mediasource/URLMediaSource.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/mediasource/WindowMediaSource.idl View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.idl View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/modules/mediastream/URLMediaStream.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/notifications/WindowNotifications.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/notifications/WorkerGlobalScopeNotifications.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/performance/SharedWorkerPerformance.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/WorkerGlobalScopePerformance.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/WindowQuota.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/speech/WindowSpeechSynthesis.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vibration/NavigatorVibration.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/webdatabase/WindowWebDatabase.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.idl View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
Just a style cleanup as part of rewrite; I'd TBR this, but it's a lot ...
6 years, 11 months ago (2014-01-14 05:47:12 UTC) #1
haraken
LGTM.
6 years, 11 months ago (2014-01-14 07:11:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/130943004/1
6 years, 11 months ago (2014-01-14 07:17:25 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 09:26:27 UTC) #4
Message was sent while issue was closed.
Change committed as 165049

Powered by Google App Engine
This is Rietveld 408576698