|
Regularize extended attributes on partial interfaces
This is cleanup CL, as part of implementing partial interfaces in the
Python IDL compiler.
Primarily it moves overall [RuntimeEnabled] extended attributes (and
[Conditional] and [PerContextEnabled]) to the partial interface itself,
rather than individual members, so:
[
RuntimeEnabled=FeatureName,
] partial interface Foo {
void a();
void b();
};
instead of:
partial interface Foo {
[RuntimeEnabled=FeatureName] void a();
[RuntimeEnabled=FeatureName] void b();
};
This is for consistency: these extended attributes can be applied
to the partial interface itself, which means they are applied to
all members, so we can switch it on or off with one line.
Currently some IDL files put this on the partial interface, while
others put it on all members; this makes it consistent and clarifies intent.
(We could remove all of these, simplifying merging a bit, at the cost
of putting these on all the individual member lines.)
Docs:
https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-Partial-interfaces
No changes to generated code.
R=haraken
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165049
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+195 lines, -175 lines) |
Patch |
 |
M |
Source/bindings/tests/idls/TestPartialInterface.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/idls/testing/SupportTestPartialInterface.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterface.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterface.cpp
|
View
|
|
6 chunks |
+96 lines, -96 lines |
0 comments
|
Download
|
 |
M |
Source/core/animation/ElementAnimation.idl
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/DocumentFontFaceSet.idl
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/DocumentFullscreen.idl
|
View
|
|
1 chunk |
+11 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/core/events/NavigatorEvents.idl
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/page/WindowPagePopup.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/xml/DocumentXPathEvaluator.idl
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
Source/modules/crypto/WindowCrypto.idl
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/crypto/WorkerGlobalScopeCrypto.idl
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/donottrack/NavigatorDoNotTrack.idl
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/filesystem/DataTransferItemFileSystem.idl
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/filesystem/HTMLInputElementFileSystem.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/modules/filesystem/WindowFileSystem.idl
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/gamepad/NavigatorGamepad.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/modules/geolocation/NavigatorGeolocation.idl
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/modules/imagebitmap/WindowImageBitmapFactories.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/indexeddb/WindowIndexedDatabase.idl
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/mediasource/HTMLVideoElementMediaSource.idl
|
View
|
|
1 chunk |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/mediasource/URLMediaSource.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/mediasource/WindowMediaSource.idl
|
View
|
|
1 chunk |
+7 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/modules/mediastream/NavigatorMediaStream.idl
|
View
|
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/modules/mediastream/URLMediaStream.idl
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/navigatorcontentutils/NavigatorContentUtils.idl
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/notifications/WindowNotifications.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/notifications/WorkerGlobalScopeNotifications.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/performance/SharedWorkerPerformance.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/performance/WorkerGlobalScopePerformance.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/quota/WindowQuota.idl
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/serviceworkers/NavigatorServiceWorker.idl
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/speech/WindowSpeechSynthesis.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/vibration/NavigatorVibration.idl
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/modules/webdatabase/WindowWebDatabase.idl
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.idl
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/modules/webmidi/NavigatorWebMIDI.idl
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|