Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1309423002:
Make DeleteSelectionCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNorma (Closed)
|
Created:
5 years, 4 months ago by yosin_UTC9 Modified:
5 years, 4 months ago CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionMake DeleteSelectionCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()
This patch changes |DeleteSelectionCommand| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.
This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002
BUG=513568
TEST=n/a; no behavior changes
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201178
Patch Set 1 : 2015-08-25T15:26:16 #
Messages
Total messages: 35 (17 generated)
Patchset #1 (id:1) has been deleted
yosin@chromium.org changed reviewers: + hajimehoshi@chromium.org, yoichio@chromium.org
PTAL
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by yosin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309423002/20001
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201178 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
