Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 1309413006: Move VisibleSelection::ChangeObserver out from VisibleSelection class (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move VisibleSelection::ChangeObserver out from VisibleSelection class This patch moves |VisibleSelection::ChangeObserver| out from |VisibleSelection| class as |VisibleSelectionChangeObserver| as preparation of introducing composed tree version of |VisibleSelection| since it doesn't depend on DOM tree traversal and composed tree traversal. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201785

Patch Set 1 : 2015-09-04T15:50:42 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M Source/core/editing/FrameSelection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleSelection.h View 3 chunks +17 lines, -15 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
yoichio
lgtm
5 years, 3 months ago (2015-09-04 07:11:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309413006/1
5 years, 3 months ago (2015-09-04 07:49:58 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 08:45:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201785

Powered by Google App Engine
This is Rietveld 408576698