impl part of SKFontMgr for mac

impl part of SKFontMgr for mac

Here is some test code

    SkFontMgr* mgr = SkFontMgr::RefDefault();
    for (int i = 0; i < mgr->countFamilies(); ++i) {
        SkString familyName;
        mgr->getFamilyName(i, &familyName);
        SkDebugf("%s\n", familyName.c_str());
        SkFontStyleSet* styles = mgr->createStyleSet(i);
        for (int j = 0; j < styles->count(); ++j) {
            SkFontStyle fs;
            SkString styleName;
            styles->getStyle(j, &fs, &styleName);
            SkTypeface* face = styles->createTypeface(j);
            SkDebugf("    %s [%d %d] %x\n", styleName.c_str(), fs.weight(),
                     fs.width(), face);
        }
        styles->unref();
    }
    mgr->unref();
Committed: https://code.google.com/p/skia/source/detail?r=8395

[reed1, 2013-03-26 17:19:20]

Committed patchset #1 manually as r8395 (presubmit successful).

[sugoi, 2013-03-26 18:03:42]

This new warning popped in on my side. I thought I'd mention it just in case...

https://codereview.chromium.org/13094005/diff/1/src/core/SkFontHost.cpp
File src/core/SkFontHost.cpp (right):

https://codereview.chromium.org/13094005/diff/1/src/core/SkFontHost.cpp#newco...
src/core/SkFontHost.cpp:66: fUnion.fR.fSlant = kUpright_Slant;
Not sure if this is the intended behavior, but there is a "slant" parameter
that's ignore and kUpright_Slant seems to be used instead. Just mentioning it in
case it was a mistake.

[reed1, 2013-03-26 18:44:01]

On 2013/03/26 18:03:42, sugoi wrote:
> This new warning popped in on my side. I thought I'd mention it just in
case...
> 
> https://codereview.chromium.org/13094005/diff/1/src/core/SkFontHost.cpp
> File src/core/SkFontHost.cpp (right):
> 
>
https://codereview.chromium.org/13094005/diff/1/src/core/SkFontHost.cpp#newco...
> src/core/SkFontHost.cpp:66: fUnion.fR.fSlant = kUpright_Slant;
> Not sure if this is the intended behavior, but there is a "slant" parameter
> that's ignore and kUpright_Slant seems to be used instead. Just mentioning it
in
> case it was a mistake.

doh, bug. thanks. fill fix.