third_party/cq_client/README.md - Issue 1309393004: Updated cq_client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cq_client/README.md

Issue 1309393004: Updated cq_client (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Added cq.pb.go Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/cq_client/README.md

diff --git a/third_party/cq_client/README.md b/third_party/cq_client/README.md

index d37caa6af563a03370323b749d2b2fe232e57b7e..f575d7495e4cd8b4281d1c165e329b95adc0c0dd 100644

--- a/third_party/cq_client/README.md

+++ b/third_party/cq_client/README.md

@@ -2,15 +2,15 @@ This directory contains CQ client library to be distributed to other repos. If

you need to modify some files in this directory, please make sure that you are

changing the canonical version of the source code and not one of the copies,

which should only be updated as a whole using Glyco (when available, see

-http://crbug.com/489420).

+[chromium issue 489420](http://crbug.com/489420)).

The canonical version is located at `https://chrome-internal.googlesource.com/

infra/infra_internal/+/master/commit_queue/cq_client`.

-To generate `cq_pb2.py`, please use protoc version 2.6.1:

+To generate `cq_pb2.py` and `cq.pb.go`, please use protoc version 2.6.1:

cd commit_queue/cq_client

- protoc cq.proto --python_out $(pwd)

+ protoc cq.proto --python_out $(pwd) --go_out $(pwd)

Additionally, please make sure to use proto3-compatible syntax, e.g. no default

values, no required fields. Ideally, we should use proto3 generator already,

« no previous file with comments | « no previous file | third_party/cq_client/cq.proto » ('j') | no next file with comments »