Source/modules/background_sync/SyncManager.h - Issue 1309393003: [Background Sync] Allow sync manager access from uncontrolled clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/background_sync/SyncManager.h

Issue 1309393003: [Background Sync] Allow sync manager access from uncontrolled clients (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Provide a body for deprecated method in preparation for removing it from subclasses Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/background_sync/PeriodicSyncManager.idl ('k') | Source/modules/background_sync/SyncManager.cpp » ('j') | public/platform/modules/background_sync/WebSyncProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/SyncManager.h

diff --git a/Source/modules/background_sync/SyncManager.h b/Source/modules/background_sync/SyncManager.h

index 25db226a587110f7101eb64dd87b96a28f8ef8a9..8690788ff913165873431dc3010cdb26b0e9fc96 100644

--- a/Source/modules/background_sync/SyncManager.h

+++ b/Source/modules/background_sync/SyncManager.h

@@ -11,6 +11,7 @@

namespace blink {

+class ExecutionContext;

class SyncRegistrationOptions;

class ScriptPromise;

class ScriptState;

@@ -26,8 +27,7 @@ public:

unsigned long minAllowablePeriod();

- ScriptPromise registerFunction(ScriptState*);

- ScriptPromise registerFunction(ScriptState*, const SyncRegistrationOptions&);

+ ScriptPromise registerFunction(ScriptState*, ExecutionContext*, const SyncRegistrationOptions&);

ScriptPromise getRegistration(ScriptState*, const String&);

ScriptPromise getRegistrations(ScriptState*);

ScriptPromise permissionState(ScriptState*);