Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1309383003: fix cascade on ThisExpression (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M lib/src/codegen/js_codegen.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +4 lines, -0 lines 0 comments Download
A test/codegen/language/cascade_in_expression_function_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 3 months ago (2015-09-04 21:45:12 UTC) #2
Leaf
lgtm
5 years, 3 months ago (2015-09-04 22:26:33 UTC) #3
Jennifer Messerly
5 years, 3 months ago (2015-09-04 22:28:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6dee1263181df719d276bdcc460e9cd0245c6e65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698