Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Issue 1309363008: Remove trailing backslash in comment causing multiline comment warning. (Closed)

Created:
5 years, 3 months ago by engedy
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, pauljensen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove trailing backslash in comment causing multiline comment warning on chromeos_amd64. BUG=514575 TBR=pneubeck@chromium.org, benwells@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4c18992a34fdd4c7a5e33d30e55a59c4aec03ebf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
engedy
This caused on issue on trybots, e.g.: http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/30111/steps/compile%20%28without%20patch%29/logs/stdio#error1 [1226/1227] CXX obj/chrome/browser/extensions/api/certificate_provider/browser_tests.certificate_provider_apitest.o FAILED: obj/chrome/browser/extensions/api/certificate_provider/browser_tests.certificate_provider_apitest.o ../../chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:246:5:error: multi-line ...
5 years, 3 months ago (2015-09-09 14:17:34 UTC) #2
engedy
Committed patchset #1 (id:1) manually as 4c18992a34fdd4c7a5e33d30e55a59c4aec03ebf (presubmit successful).
5 years, 3 months ago (2015-09-09 14:19:53 UTC) #3
pneubeck (no reviews)
lgtm
5 years, 3 months ago (2015-09-09 14:23:19 UTC) #4
engedy
5 years, 3 months ago (2015-09-09 14:26:44 UTC) #5
Message was sent while issue was closed.
On 2015/09/09 14:23:19, pneubeck wrote:
> lgtm

Please feel free to adjust the comment format as you see fit, we just didn't
want to overthink how to do it, but wanted to make the trybots green ASAP.

Powered by Google App Engine
This is Rietveld 408576698