[sessions] Remove most knowledge of //chrome from core tab restore code

chrome/browser/sessions/chrome_tab_restore_service_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SESSIONS_CHROME_TAB_RESTORE_SERVICE_CLIENT_H_
 #define CHROME_BROWSER_SESSIONS_CHROME_TAB_RESTORE_SERVICE_CLIENT_H_
 
 #include "base/basictypes.h"
 #include "components/sessions/core/tab_restore_service_client.h"
 
 class Profile;
 
 // ChromeTabRestoreServiceClient provides an implementation of
 // TabRestoreServiceClient that depends on chrome/.
 class ChromeTabRestoreServiceClient : public sessions::TabRestoreServiceClient {
  public:
   explicit ChromeTabRestoreServiceClient(Profile* profile);
   ~ChromeTabRestoreServiceClient() override;
 
  private:
   // TabRestoreServiceClient:
+  base::FilePath GetPathToSaveTo() override;
+  GURL GetNewTabURL() override;
   bool HasLastSession() override;
   void GetLastSession(const sessions::GetLastSessionCallback& callback,
                       base::CancelableTaskTracker* tracker) override;
+  void OnTabRestored(const GURL& url) override;

[sky, 2015/09/09 15:57:59]

Is it possible to have the call sites do this book keeping?

[blundell, 2015/09/09 16:03:13]

By "bookkeeping", are you referring to the body of RecordAppLaunch()? If so, the
reason that this isn't possible is because //components isn't allowed to depend
on //extensions.

[sky, 2015/09/09 19:52:05]

I was thinking more specifically if the places that call into the
TabRestoreService to initiate a restore could change to initiate the restore and
then log the metrics?

 
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeTabRestoreServiceClient);
 };
 
 #endif  // CHROME_BROWSER_SESSIONS_CHROME_TAB_RESTORE_SERVICE_CLIENT_H_