Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1309343002: On remote frame's (re)attachment, connect its widget. (Closed)

Created:
5 years, 4 months ago by lazyboy
Modified:
5 years, 3 months ago
Reviewers:
dcheng
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

On remote frame's (re)attachment, connect its widget. A remote frame can be detached by setting its .style.display = 'none'. If we attach it again by setting its .style.display = '', the frame becomes widget/FrameView-less. This CL sets the widget of the frame. BUG=517291 Test=With --site-per-process, navigate an <iframe> to cross site. See that resizing the frame works correctly, e.g.: document.querySelector('iframe').style.width = '400px'; Now hide the iframe, and then make it visible: document.querySelector('iframe').style.display = 'none'; document.querySelector('iframe').style.display = ''; See that resizing the frame still works correctly. It will fail without this CL. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/html/HTMLFrameElementBase.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
lazyboy
5 years, 4 months ago (2015-08-24 22:02:01 UTC) #2
dcheng
lgtm
5 years, 4 months ago (2015-08-24 23:50:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309343002/1
5 years, 3 months ago (2015-08-25 22:03:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-25 22:08:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309343002/1
5 years, 3 months ago (2015-08-25 22:09:41 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 22:14:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201161

Powered by Google App Engine
This is Rietveld 408576698