Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1309303008: Make type-feedback-vector.h usable without objects-inl.h header (and others). (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make type-feedback-vector.h usable without objects-inl.h header (and others). Pure refactoring to further reduce the header dependency tangle. BUG= R=mstarzinger@chromium.org Committed: https://crrev.com/fa530822fd0c3ead1d8e86c8179407fecdd1e1db Cr-Commit-Position: refs/heads/master@{#30508}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -95 lines) Patch
M src/type-feedback-vector.h View 3 chunks +25 lines, -95 lines 0 comments Download
M src/type-feedback-vector-inl.h View 2 chunks +133 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Michael, here is the CL we discussed. PTAL, thanks! --Michael
5 years, 3 months ago (2015-09-01 11:34:28 UTC) #1
Michael Starzinger
Awesome. Thanks! LGTM with one comment to address. https://codereview.chromium.org/1309303008/diff/1/src/type-feedback-vector.cc File src/type-feedback-vector.cc (left): https://codereview.chromium.org/1309303008/diff/1/src/type-feedback-vector.cc#oldcode5 src/type-feedback-vector.cc:5: #include ...
5 years, 3 months ago (2015-09-01 11:43:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309303008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309303008/20001
5 years, 3 months ago (2015-09-01 12:03:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 12:28:15 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 12:28:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa530822fd0c3ead1d8e86c8179407fecdd1e1db
Cr-Commit-Position: refs/heads/master@{#30508}

Powered by Google App Engine
This is Rietveld 408576698