Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1309303006: Propagate switch statement value for 'eval' (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Propagate switch statement value for 'eval' This patch changes the switch scope desugaring to create blocks which propagate their 'return value' for eval. BUG=v8:4399 R=adamk LOG=Y Committed: https://crrev.com/6773e2961de8f9e588cbf0e939ab3f325dd6fef9 Cr-Commit-Position: refs/heads/master@{#30454}

Patch Set 1 #

Patch Set 2 : undefined; #

Total comments: 1

Patch Set 3 : additional tests #

Patch Set 4 : Fix AST tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M src/parser.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4399.js View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Dan Ehrenberg
5 years, 3 months ago (2015-08-28 21:01:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309303006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309303006/1
5 years, 3 months ago (2015-08-28 21:01:46 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9188)
5 years, 3 months ago (2015-08-28 21:28:50 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309303006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309303006/20001
5 years, 3 months ago (2015-08-28 21:59:27 UTC) #7
adamk
lgtm, though as discussed offline please add a test case to the regression test for ...
5 years, 3 months ago (2015-08-28 22:03:20 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9228)
5 years, 3 months ago (2015-08-28 22:07:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309303006/30003 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309303006/30003
5 years, 3 months ago (2015-08-28 22:08:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/9115) v8_mac_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-08-28 22:17:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309303006/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309303006/50001
5 years, 3 months ago (2015-08-28 22:20:13 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 3 months ago (2015-08-28 22:43:07 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 22:43:14 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6773e2961de8f9e588cbf0e939ab3f325dd6fef9
Cr-Commit-Position: refs/heads/master@{#30454}

Powered by Google App Engine
This is Rietveld 408576698