Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1309303005: PPC: Make Simulator respect C stack limits as well. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Make Simulator respect C stack limits as well. Port 7fb31bdba4f2a0320507956a085f083d76bce48c Original commit message: The simulator uses a separate JS stack, exhaustion of the C stack however is not caught by JS limit checks. This change now lowers the limit of the JS stack accordingly on function calls. R=mstarzinger@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG=chromium:522380 LOG=n Committed: https://crrev.com/bcc9df92734786e2c3dc51eca7ee684cf8e930cd Cr-Commit-Position: refs/heads/master@{#30413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/ppc/simulator-ppc.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-26 22:49:48 UTC) #1
JoranSiu
lgtm
5 years, 3 months ago (2015-08-27 02:05:55 UTC) #2
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-08-27 07:33:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309303005/1
5 years, 3 months ago (2015-08-27 13:30:16 UTC) #5
dstence
lgtm
5 years, 3 months ago (2015-08-27 13:35:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 14:01:55 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 14:02:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcc9df92734786e2c3dc51eca7ee684cf8e930cd
Cr-Commit-Position: refs/heads/master@{#30413}

Powered by Google App Engine
This is Rietveld 408576698