Issue 13093: Fixed d8 on leopard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13093: Fixed d8 on leopard. (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Made d8 console=readline work on leopard.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -5 lines)			Patch
M	src/d8-readline.cc	View	4 chunks	+8 lines, -2 lines	1 comment	Download
M	src/platform.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+16 lines, -1 line	1 comment	Download
M	src/platform-win32.cc	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-12-03 13:43:22 UTC) #2

LGTM

http://codereview.chromium.org/13093/diff/1/2
File src/d8-readline.cc (right):

http://codereview.chromium.org/13093/diff/1/2#newcode37
Line 37: #if RL_READLINE_VERSION >= 0x0500
I think this deserves a comment.

http://codereview.chromium.org/13093/diff/1/5
File src/platform-macos.cc (right):

http://codereview.chromium.org/13093/diff/1/5#newcode202
Line 202: if (len < n)
Might as well use StrDup for the case where len == n.

http://codereview.chromium.org/13093/diff/1/6
File src/platform-win32.cc (right):

http://codereview.chromium.org/13093/diff/1/6#newcode698
Line 698: char* OS::StrDup(const char* str) {
Wot no strndup?

Expand Messages | Collapse Messages