Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309283002: Remove include of RetainPtr.h in Image.h. (Closed)

Created:
5 years, 4 months ago by jbroman
Modified:
5 years, 4 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove include of RetainPtr.h in Image.h. This file does not use RetainPtr. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/platform/graphics/Image.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
jbroman
5 years, 4 months ago (2015-08-25 14:59:28 UTC) #2
pdr.
lgtm
5 years, 4 months ago (2015-08-25 17:22:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309283002/1
5 years, 4 months ago (2015-08-25 17:22:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103986)
5 years, 4 months ago (2015-08-25 19:06:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309283002/1
5 years, 4 months ago (2015-08-25 19:19:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104096)
5 years, 4 months ago (2015-08-25 20:11:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309283002/1
5 years, 4 months ago (2015-08-26 03:27:35 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 04:35:54 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201197

Powered by Google App Engine
This is Rietveld 408576698