native_viewport support for ozone

services/native_viewport/ozone/display_manager.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_NATIVE_VIEWPORT_DISPLAY_MANAGER_H_
+#define SERVICES_NATIVE_VIEWPORT_DISPLAY_MANAGER_H_
+
+#include <vector>
+#include "ui/display/types/native_display_delegate.h"
+#include "ui/display/types/native_display_observer.h"
+#include "ui/gfx/geometry/rect.h"
+
+namespace native_viewport {
+
+class DisplayManager : public ui::NativeDisplayObserver {
+ public:
+  DisplayManager();
+  ~DisplayManager() override;
+
+ private:
+  void OnDisplaysAquired(const std::vector<ui::DisplaySnapshot*>& displays);
+  void OnDisplayConfigured(const gfx::Rect& bounds, bool success);
+
+  // ui::NativeDisplayObserver
+  void OnConfigurationChanged() override;
+
+  scoped_ptr<ui::NativeDisplayDelegate> delegate_;
+
+  // Flags used to keep track of the current state of display configuration.
+  //
+  // True if configuring the displays. In this case a new display configuration
+  // isn't started.
+  bool is_configuring_ = false;

[jamesr, 2015/08/25 00:30:28]

guideline for member initialization like this is to do it if *all* members can
be initialized in the declaration.  here delegate_ is initialized to something
else in the constructor, so figuring out the initial state of the members
requires reading both the declaration and the constructor which is a loss. it's
better to initialize all of the members in the constructor definition for this
case

[cdotstout, 2015/08/27 19:10:21]

Done.

+
+  // If |is_configuring_| is true and another display configuration event
+  // happens, the event is deferred. This is set to true and a display
+  // configuration will be scheduled after the current one finishes.
+  bool should_configure_ = false;
+
+  DISALLOW_COPY_AND_ASSIGN(DisplayManager);
+};
+
+}  // namespace

[jamesr, 2015/08/25 00:30:28]

}  // namespace native_viewport

[cdotstout, 2015/08/27 19:10:21]

Done.

+
+#endif