Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309253002: Add build targets for advanced Intel instruction sets (1.5 of 3) (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add build targets for advanced Intel instruction sets (1.5 of 3) This is a follow-up to https://codereview.chromium.org/1290423007/, with a couple small changes: - turn on AVX and AVX2 for Windows using /arch ('EnabledEnhancedInstructionSet') - reformat and de-conditionalize where possible / irrelevant Picked up this while poking around in libvpx's Chrome GYPs. And yes, AVX = 3, AVX2 = 5. Don't even ask what 4 means... BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/85533968a81097322cc4e883448c1594ae868594

Patch Set 1 #

Patch Set 2 : 3 -> avx, 5 -> avx2, 4 -> none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M gyp/opts.gyp View 1 5 chunks +14 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309253002/1
5 years, 4 months ago (2015-08-24 19:28:54 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 19:33:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309253002/20001
5 years, 4 months ago (2015-08-24 19:39:53 UTC) #6
mtklein_C
5 years, 4 months ago (2015-08-24 19:44:48 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 19:45:05 UTC) #10
djsollen
lgtm
5 years, 4 months ago (2015-08-25 13:03:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309253002/20001
5 years, 4 months ago (2015-08-25 13:29:35 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 13:30:16 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/85533968a81097322cc4e883448c1594ae868594

Powered by Google App Engine
This is Rietveld 408576698