Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1309243004: Reland again [Startup Tracing] Add --trace-config-file flag (Closed)

Created:
5 years, 3 months ago by Zhen Wang
Modified:
5 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, penghuang+watch-mandoline_chromium.org, tracing+reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland again [Startup Tracing] Add --trace-config-file flag Original CL: https://codereview.chromium.org/1315463002/ 1st reland: https://codereview.chromium.org/1317333002/ -------- This CL adds --trace-config-file flag. Please see trace_config_file.h for details. Design doc: https://docs.google.com/document/d/1PgdXUOJF3WtEmYWUyGRbC2Fz2ICCZKO9jPvpLPRSHH8/edit?usp=sharing BUG=317481, 482098 TBR=dsinclair@chromium.org,blundell@chromium.org,sievers@chromium.org,sky@chromium.org,msw@chromium.org Committed: https://crrev.com/c074d28f557ee0996efb3aa584b8932e1beb837e Cr-Commit-Position: refs/heads/master@{#346407}

Patch Set 1 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -143 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
M components/tracing.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M components/tracing/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
D components/tracing/startup_tracing.h View 1 chunk +0 lines, -20 lines 0 comments Download
D components/tracing/startup_tracing.cc View 1 chunk +0 lines, -66 lines 0 comments Download
A components/tracing/trace_config_file.h View 1 chunk +94 lines, -0 lines 0 comments Download
A components/tracing/trace_config_file.cc View 1 chunk +140 lines, -0 lines 0 comments Download
A components/tracing/trace_config_file_unittest.cc View 1 1 chunk +220 lines, -0 lines 0 comments Download
M components/tracing/tracing_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing/tracing_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/tracing_nacl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/browser_main_loop.h View 5 chunks +7 lines, -5 lines 0 comments Download
M content/browser/browser_main_loop.cc View 5 chunks +43 lines, -27 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +19 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mandoline/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhen Wang
The compile error on Win x64 GN is now fixed. The trybot verion for that ...
5 years, 3 months ago (2015-08-31 16:19:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309243004/20001
5 years, 3 months ago (2015-08-31 16:19:32 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-31 17:28:28 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 17:29:04 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c074d28f557ee0996efb3aa584b8932e1beb837e
Cr-Commit-Position: refs/heads/master@{#346407}

Powered by Google App Engine
This is Rietveld 408576698