src/harmony-array.js - Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/harmony-array.js

Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed nit: use factory()->ToBoolean() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/harmony-array.js

diff --git a/src/harmony-array.js b/src/harmony-array.js

index 705adcd06a30339082d8138c0d3bb302904276d5..50da5f9b1f961fd403aa2ea2a396946ea980607d 100644

--- a/src/harmony-array.js

+++ b/src/harmony-array.js

@@ -173,7 +173,7 @@ function ArrayFill(value, start, end) {

CHECK_OBJECT_COERCIBLE(this, "Array.prototype.fill");

var array = TO_OBJECT(this);

- var length = TO_UINT32(array.length);

+ var length = TO_LENGTH_OR_UINT32(array.length);

return InnerArrayFill(value, start, end, array, length);

}

« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/heap.h » ('j') | no next file with comments »