src/runtime.js - Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.js

Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use a TO_LENGTH macro instead of the ToLengthFlagged function Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.js

diff --git a/src/runtime.js b/src/runtime.js

index e5e306d8cd83a32fd6510004b58a3bd5beefa4a4..12100ff1e091488f7a9e1e07a3e1ee401b13da40 100644

--- a/src/runtime.js

+++ b/src/runtime.js

@@ -24,6 +24,8 @@ var $toPositiveInteger;

var $toPrimitive;

var $toString;

+var harmony_tolength = false;

(function(global, utils) {

%CheckIsBootstrapping();

@@ -653,7 +655,6 @@ function ToLength(arg) {

: GlobalNumber.MAX_SAFE_INTEGER;

}

aperez 2015/09/09 18:20:45 Also, I noticed this bogus line removal here. I'm

// ES5, section 9.12

function SameValue(x, y) {

if (typeof x != typeof y) return false;

« src/object-observe.js ('K') | « src/object-observe.js ('k') | test/mjsunit/harmony/array-length.js » ('j') | no next file with comments »