src/heap/heap.h - Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.h

Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use a TO_LENGTH macro instead of the ToLengthFlagged function Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.h

diff --git a/src/heap/heap.h b/src/heap/heap.h

index 58f7a7bb7199c618ce143296cf7c36ac7846cd8e..87d92204d9ba9ac5002b61a28ddc40044b6c3198 100644

--- a/src/heap/heap.h

+++ b/src/heap/heap.h

@@ -259,6 +259,10 @@ namespace internal {

V(multiline_string, "multiline") \

V(sticky_string, "sticky") \

V(unicode_string, "unicode") \

+ V(harmony_regexps_string, "harmony_regexps") \

+ V(harmony_tostring_string, "harmony_tostring") \

+ V(harmony_unicode_regexps_string, "harmony_unicode_regexps") \

Camillo Bruni 2015/09/09 13:51:16 Are these here on purpose?

aperez 2015/09/09 18:20:45 Ouch, leftovers from rebasing, I'll remove them.

+ V(harmony_tolength_string, "harmony_tolength") \

V(input_string, "input") \

V(index_string, "index") \

V(last_index_string, "lastIndex") \

« no previous file with comments | « src/harmony-array.js ('k') | src/macros.py » ('j') | src/macros.py » ('J')