Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/debug/liveedit.js

Issue 1309243003: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/liveedit.js
diff --git a/src/debug/liveedit.js b/src/debug/liveedit.js
index 27425c154d03a1bf34e56cf688db6a4c7312b7c4..685eebdde7f1ad808d95fa99bf41da7b37cecaa4 100644
--- a/src/debug/liveedit.js
+++ b/src/debug/liveedit.js
@@ -216,10 +216,10 @@
position_patch_report);
if (update_positions_list[i].live_shared_function_infos) {
- update_positions_list[i].live_shared_function_infos.
- forEach(function (info) {
- %LiveEditFunctionSourceUpdated(info.raw_array);
- });
+ for (var j = 0; j < update_positions_list[i].live_shared_function_infos.length; j++) {
Camillo Bruni 2015/09/08 07:10:34 Did you change this on purpose? Seems unrelated to
aperez 2015/09/09 12:48:43 Now that I am changing the code to use a macro I c
+ var info = update_positions_list[i].live_shared_function_infos[j];
+ %LiveEditFunctionSourceUpdated(info.raw_array);
+ }
}
}
« no previous file with comments | « src/bootstrapper.cc ('k') | src/flag-definitions.h » ('j') | src/object-observe.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698