ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32

src/debug/liveedit.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // LiveEdit feature implementation. The script should be executed after
 // debug.js.
 
 // A LiveEdit namespace. It contains functions that modifies JavaScript code
 // according to changes of script source (if possible).
 //
@@ skipping 198 matching lines @@
     var position_patch_report = new GlobalArray();
     change_log.push( {position_patched: position_patch_report} );
 
     for (var i = 0; i < update_positions_list.length; i++) {
       // TODO(LiveEdit): take into account whether it's source_changed or
       // unchanged and whether positions changed at all.
       PatchPositions(update_positions_list[i], diff_array,
           position_patch_report);
 
       if (update_positions_list[i].live_shared_function_infos) {
-        update_positions_list[i].live_shared_function_infos.
-            forEach(function (info) {
-                %LiveEditFunctionSourceUpdated(info.raw_array);
-              });
+        for (var j = 0; j < update_positions_list[i].live_shared_function_infos.length; j++) {

[Camillo Bruni, 2015/09/08 07:10:34]

Did you change this on purpose? Seems unrelated to your fix.

[aperez, 2015/09/09 12:48:43]

Now that I am changing the code to use a macro I can revert this change and
leave the code as it was.

+          var info = update_positions_list[i].live_shared_function_infos[j];
+          %LiveEditFunctionSourceUpdated(info.raw_array);
+        }
       }
     }
 
     break_points_restorer(pos_translator, old_script);
 
     preview_description.updated = true;
     return preview_description;
   }
 
   // Fully compiles source string as a script. Returns Array of
@@ skipping 881 matching lines @@
 
   LiveEdit.TestApi = {
     PosTranslator: PosTranslator,
     CompareStrings: CompareStrings,
     ApplySingleChunkPatch: ApplySingleChunkPatch
   };
 
   global.Debug.LiveEdit = LiveEdit;
 
 })