Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 1309233008: Move applications using play services to the shell. (Closed)

Created:
5 years, 3 months ago by qsr
Modified:
5 years, 3 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move applications using play services to the shell. Play services must be configured at the apk level. This means that services that depend on those need to be in the shell. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a6fb7a27935ab2e07c44fefbbe7623578795edab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -253 lines) Patch
M services/authentication/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
D services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java View 1 chunk +0 lines, -72 lines 0 comments Download
A + services/authentication/src/org/chromium/mojo/authentication/AuthenticationApplicationDelegate.java View 2 chunks +2 lines, -9 lines 0 comments Download
M services/location/BUILD.gn View 1 chunk +6 lines, -12 lines 0 comments Download
A + services/location/src/org/chromium/services/location/LocationApplicationDelegate.java View 3 chunks +5 lines, -12 lines 0 comments Download
D services/location/src/org/chromium/services/location/LocationServiceApp.java View 1 chunk +0 lines, -142 lines 0 comments Download
M shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/JavaApplicationRegistry.java View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qsr
5 years, 3 months ago (2015-09-08 11:21:06 UTC) #1
ppi
lgtm
5 years, 3 months ago (2015-09-08 11:36:20 UTC) #2
qsr
5 years, 3 months ago (2015-09-08 11:48:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6fb7a27935ab2e07c44fefbbe7623578795edab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698