Issue 130923002: Make GN pass -target flags only on Android Clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130923002: Make GN pass -target flags only on Android Clang (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make GN pass -target flags only on Android Clang This fails on other configurations. The new behavior matches the GYP build. R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243930

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	build/config/compiler/BUILD.gn	View	1	1 chunk	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/130923002/30001

6 years, 11 months ago (2014-01-09 06:34:48 UTC) #2

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243987

6 years, 11 months ago (2014-01-09 10:39:56 UTC) #4

brettw

6 years, 11 months ago (2014-01-09 18:34:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r243930 (presubmit successful).

Expand Messages | Collapse Messages