Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 1309163006: MIPS: Fix MacroAssembler::AssertFunction() (Closed)

Created:
5 years, 3 months ago by paul.l...
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix MacroAssembler::AssertFunction() Porting mistake in ccbb4ff0 '[builtins] Unify the various versions of [[Call]] with a Call builtin.', which only showed as debug assertion in later commit db2ba190 '[runtime] Replace many buggy uses of %_CallFunction with %_Call.' Use temporary register rather than push/pop of 'object' register. BUG= TEST=cctest/test-api/SetFunctionEntryHook, cctest/test-serialize/PerIsolateSnapshotBlobs, ... Committed: https://crrev.com/444a933931b405bd33485e8c299ee850b47a9531 Cr-Commit-Position: refs/heads/master@{#30643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
paul.l...
PTAL
5 years, 3 months ago (2015-09-08 18:32:40 UTC) #2
akos.palfi.imgtec
LGTM
5 years, 3 months ago (2015-09-08 18:49:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309163006/1
5 years, 3 months ago (2015-09-08 19:02:39 UTC) #5
Benedikt Meurer
LGTM, thanks for fixing this.
5 years, 3 months ago (2015-09-08 19:13:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 19:29:29 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 19:29:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/444a933931b405bd33485e8c299ee850b47a9531
Cr-Commit-Position: refs/heads/master@{#30643}

Powered by Google App Engine
This is Rietveld 408576698