Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1309153003:
Remove container overflow tests for Vectors with inline capacity (Closed)
|
Created:
5 years, 4 months ago by Oliver Chang Modified:
5 years, 4 months ago CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionRemove container overflow tests for Vectors with inline capacity
since builds with these checks have inline capacity disabled.
R=thakis@chromium.org, inferno@chromium.org
TBR=thakis
BUG=524162
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201136
Patch Set 1 #
Messages
Total messages: 23 (9 generated)
rs-lgtm https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... has a TODO to fix things in 32-bit, is that done? (This CL disables tests on 32-bit linux. I guess we don't have many bots in that config anymore so it's not a big deal.)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309153003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309153003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
aarya@google.com changed reviewers: + tkent@chromium.org
On 2015/08/25 15:30:53, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. …I'm definitely in Source/wtf/OWNERS. Not sure why this is a problem.
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309153003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309153003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 201136 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
