Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/support/html_output/results-template.html

Issue 1309143006: [Telemetry] Update the ConfindenceInterval calculation in results.html to use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address petrcermak's comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/results/html_output_formatter.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/support/html_output/results-template.html
diff --git a/tools/telemetry/support/html_output/results-template.html b/tools/telemetry/support/html_output/results-template.html
index b79812da31793b742fd6a949a8bdbfe345af0da9..7487d9025631f94b0080e7674e23d5385d4ad537 100644
--- a/tools/telemetry/support/html_output/results-template.html
+++ b/tools/telemetry/support/html_output/results-template.html
@@ -279,7 +279,7 @@ var PADDING_UNDER_GRAPH = 5;
// px Indentation for nested children left-margins
var INDENTATION = 40;
-function TestResult(metric, values, associatedRun) {
+function TestResult(metric, values, associatedRun, std, degreesOfFreedom) {
if (values) {
if (values[0] instanceof Array) {
var flattenedValues = [];
@@ -321,6 +321,10 @@ function TestResult(metric, values, associatedRun) {
this.min = function () { return metric.scalingFactor() * Statistics.min(values); }
this.max = function () { return metric.scalingFactor() * Statistics.max(values); }
this.confidenceIntervalDelta = function () {
+ if (std !== undefined) {
+ return metric.scalingFactor() * Statistics.confidenceIntervalDeltaFromStd(0.95, values.length,
Yuta Kitamura 2015/09/28 04:32:37 On my environment, I consistently see the followin
nednguyen 2015/09/28 15:33:23 I cannot reproduce this error (see http://imgur.co
+ std, degreesOfFreedom);
+ }
return metric.scalingFactor() * Statistics.confidenceIntervalDelta(0.95, values.length,
Statistics.sum(values), Statistics.squareSum(values));
}
@@ -1359,7 +1363,10 @@ function init() {
metric = new PerfTestMetric(testName, metricName, rawMetrics[metricName].units, rawMetrics[metricName].important);
metrics[fullMetricName] = metric;
}
- metric.addResult(new TestResult(metric, rawMetrics[metricName].current, run));
+ // std & degrees_of_freedom could be undefined
+ metric.addResult(
+ new TestResult(metric, rawMetrics[metricName].current,
+ run, rawMetrics[metricName].['std'], rawMetrics[metricName]['degrees_of_freedom']));
}
}
}
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/results/html_output_formatter.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698