Add UMA metrics to record the size of internal memory available on a user's device when the Update …

base/android/record_histogram.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/record_histogram.h"
 
 #include <map>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 67 matching lines @@
       return histogram;
     }
 
     std::string histogram_name = ConvertJavaStringToUTF8(env, j_histogram_name);
     histogram =
         Histogram::FactoryGet(histogram_name, min, max, num_buckets,
                               HistogramBase::kUmaTargetedHistogramFlag);
     return InsertLocked(j_histogram_key, histogram);
   }
 
+  HistogramBase* LinearCountHistogram(JNIEnv* env,
+                                        jstring j_histogram_name,

[Yaron, 2015/08/31 13:53:21]

nit: fix indentation

+                                        jint j_histogram_key,
+                                        jint j_min,
+                                        jint j_max,
+                                        jint j_num_buckets) {
+      DCHECK(j_histogram_name);
+      DCHECK(j_histogram_key);
+      int64 min = static_cast<int64>(j_min);
+      int64 max = static_cast<int64>(j_max);
+      int num_buckets = static_cast<int>(j_num_buckets);
+      HistogramBase* histogram = FindLocked(j_histogram_key);
+      if (histogram) {
+        DCHECK(histogram->HasConstructionArguments(min, max, num_buckets));
+        return histogram;
+      }
+      std::string histogram_name = ConvertJavaStringToUTF8(env, j_histogram_name);

[Yaron, 2015/08/31 13:53:21]

80 cols

+      histogram =
+          LinearHistogram::FactoryGet(histogram_name, min, max, num_buckets,
+                                HistogramBase::kUmaTargetedHistogramFlag);

[Yaron, 2015/08/31 13:53:21]

nit: indentation

+      return InsertLocked(j_histogram_key, histogram);
+    }
+
   HistogramBase* SparseHistogram(JNIEnv* env,
                                  jstring j_histogram_name,
                                  jint j_histogram_key) {
     DCHECK(j_histogram_name);
     DCHECK(j_histogram_key);
     HistogramBase* histogram = FindLocked(j_histogram_key);
     if (histogram)
       return histogram;
 
     std::string histogram_name = ConvertJavaStringToUTF8(env, j_histogram_name);
@@ skipping 84 matching lines @@
                                 jint j_max,
                                 jint j_num_buckets) {
   int sample = static_cast<int>(j_sample);
 
   g_histograms.Get()
       .CustomCountHistogram(env, j_histogram_name, j_histogram_key, j_min,
                             j_max, j_num_buckets)
       ->Add(sample);
 }
 
+void RecordLinearCountHistogram(JNIEnv* env,
+                                jclass clazz,
+                                jstring j_histogram_name,
+                                jint j_histogram_key,
+                                jint j_sample,
+                                jint j_min,
+                                jint j_max,
+                                jint j_num_buckets) {
+  int sample = static_cast<int>(j_sample);
+
+  g_histograms.Get()
+      .LinearCountHistogram(env, j_histogram_name, j_histogram_key, j_min,
+                            j_max, j_num_buckets)
+      ->Add(sample);
+}
+
 void RecordSparseHistogram(JNIEnv* env,
                                  jclass clazz,
                                  jstring j_histogram_name,
                                  jint j_histogram_key,
                                  jint j_sample) {
     int sample = static_cast<int>(j_sample);
     g_histograms.Get()
         .SparseHistogram(env, j_histogram_name, j_histogram_key)
         ->Add(sample);
 }
@@ skipping 34 matching lines @@
   scoped_ptr<HistogramSamples> samples = histogram->SnapshotSamples();
   return samples->GetCount(static_cast<int>(sample));
 }
 
 bool RegisterRecordHistogram(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace base