Templetized SkWriter32 readTAt() & overwriteTAt()

src/core/SkPictureRecord.h

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkPictureRecord_DEFINED
 #define SkPictureRecord_DEFINED
 
@@ skipping 138 matching lines @@
             fWriter.writeInt(PACK_8_24(drawType, *size));
         }
 
         return offset;
     }
 
     void addInt(int value) {
         fWriter.writeInt(value);
     }
     void addScalar(SkScalar scalar) {
-        fWriter.writeScalar(scalar);
+        fWriter.writeT<SkScalar>(scalar);

[mtklein, 2014/02/06 21:38:16]

This may just be me, but when I see a call like this I assume we're giving the
type explicitly to force a type onto the argument.  I'd generally prefer to see
this as fWriter.writeT(scalar) for simple call sites, so that if we do see an
fWriter.writeT<SomeType>(x) we can know we've got some tricky reason to mention
the type.

[f(malita), 2014/02/10 16:10:35]

Will do.

     }
 
     void addBitmap(const SkBitmap& bitmap);
     void addMatrix(const SkMatrix& matrix);
     const SkFlatData* addPaint(const SkPaint& paint) { return this->addPaintPtr(&paint); }
     const SkFlatData* addPaintPtr(const SkPaint* paint);
     void addFlatPaint(const SkFlatData* flatPaint);
     void addPath(const SkPath& path);
     void addPicture(SkPicture& picture);
     void addPoint(const SkPoint& point);
@@ skipping 104 matching lines @@
     uint32_t fRecordFlags;
     int fInitialSaveCount;
 
     friend class SkPicturePlayback;
     friend class SkPictureTester; // for unit testing
 
     typedef SkCanvas INHERITED;
 };
 
 #endif