Issue 130913007: Exclude download_menu from Android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130913007: Exclude download_menu from Android builds. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)

Modified:
6 years, 10 months ago

Reviewers:
newt (away)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Exclude download_menu from Android builds. Chrome for Android does not use Download Menu so it should not include strings for it. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247658

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -137 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+129 lines, -137 lines	0 comments	Download
	M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hey Newton, Please take a look at this change. Thanks, Aurimas

6 years, 10 months ago (2014-01-28 23:54:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/130913007/1

6 years, 10 months ago (2014-01-29 00:57:52 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217630

6 years, 10 months ago (2014-01-29 02:04:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/130913007/1

6 years, 10 months ago (2014-01-29 02:28:34 UTC) #5

Message was sent while issue was closed.

Change committed as 247658

Expand Messages | Collapse Messages