Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: runtime/vm/class_finalizer.h

Issue 1309113004: Change trail from GrowableObjectArray to ZoneGrowableArray. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Formatting Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | runtime/vm/object.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_CLASS_FINALIZER_H_ 5 #ifndef VM_CLASS_FINALIZER_H_
6 #define VM_CLASS_FINALIZER_H_ 6 #define VM_CLASS_FINALIZER_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/growable_array.h" 9 #include "vm/growable_array.h"
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 const GrowableObjectArray& cloned_funcs); 137 const GrowableObjectArray& cloned_funcs);
138 static void CollectTypeArguments(const Class& cls, 138 static void CollectTypeArguments(const Class& cls,
139 const Type& type, 139 const Type& type,
140 const GrowableObjectArray& collected_args); 140 const GrowableObjectArray& collected_args);
141 static RawType* ResolveMixinAppType(const Class& cls, 141 static RawType* ResolveMixinAppType(const Class& cls,
142 const MixinAppType& mixin_app_type); 142 const MixinAppType& mixin_app_type);
143 static void ResolveSuperTypeAndInterfaces(const Class& cls, 143 static void ResolveSuperTypeAndInterfaces(const Class& cls,
144 GrowableArray<intptr_t>* visited); 144 GrowableArray<intptr_t>* visited);
145 static void FinalizeTypeParameters(const Class& cls, 145 static void FinalizeTypeParameters(const Class& cls,
146 GrowableObjectArray* pending_types = NULL); 146 GrowableObjectArray* pending_types = NULL);
147 static void FinalizeTypeArguments(const Class& cls, 147 static void FinalizeTypeArguments(
148 const TypeArguments& arguments, 148 const Class& cls,
149 intptr_t num_uninitialized_arguments, 149 const TypeArguments& arguments,
150 Error* bound_error, 150 intptr_t num_uninitialized_arguments,
151 GrowableObjectArray* pending_types, 151 Error* bound_error,
152 GrowableObjectArray* trail); 152 GrowableObjectArray* pending_types,
regis 2015/08/27 02:30:25 Will you do it next for pending_types?
srdjan 2015/08/27 16:09:49 Maybe. The priority is to fix issues for backgroun
153 ZoneGrowableArray<const Instance*>* trail);
153 static void CheckRecursiveType(const Class& cls, 154 static void CheckRecursiveType(const Class& cls,
154 const Type& type, 155 const Type& type,
155 GrowableObjectArray* pending_types); 156 GrowableObjectArray* pending_types);
156 static void CheckTypeBounds(const Class& cls, const Type& type); 157 static void CheckTypeBounds(const Class& cls, const Type& type);
157 static void CheckTypeArgumentBounds(const Class& cls, 158 static void CheckTypeArgumentBounds(const Class& cls,
158 const TypeArguments& arguments, 159 const TypeArguments& arguments,
159 Error* bound_error); 160 Error* bound_error);
160 static void ResolveUpperBounds(const Class& cls); 161 static void ResolveUpperBounds(const Class& cls);
161 static void FinalizeUpperBounds(const Class& cls); 162 static void FinalizeUpperBounds(const Class& cls);
162 static void ResolveAndFinalizeSignature(const Class& cls, 163 static void ResolveAndFinalizeSignature(const Class& cls,
(...skipping 17 matching lines...) Expand all
180 const char* format, ...) PRINTF_ATTRIBUTE(4, 5); 181 const char* format, ...) PRINTF_ATTRIBUTE(4, 5);
181 182
182 // Verify implicit offsets recorded in the VM for direct access to fields of 183 // Verify implicit offsets recorded in the VM for direct access to fields of
183 // Dart instances (e.g: _TypedListView, _ByteDataView). 184 // Dart instances (e.g: _TypedListView, _ByteDataView).
184 static void VerifyImplicitFieldOffsets(); 185 static void VerifyImplicitFieldOffsets();
185 }; 186 };
186 187
187 } // namespace dart 188 } // namespace dart
188 189
189 #endif // VM_CLASS_FINALIZER_H_ 190 #endif // VM_CLASS_FINALIZER_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698