Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1309113003: PPC: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. Port 00df60d1c6943a10fb5ca84fce2c017dcd2001f5 Original commit message: Makes the following modifications to the interpreter builtins and InterpreterAssembler: - Adds an accumulator register and initializes it to undefined() - Adds a register file pointer register and use it instead of FramePointer to access registers - Modifies builtin to support functions with 0 regiters in the register file - Modifies builtin to Call rather than TailCall to first bytecode handler. R=rmcilroy@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/f481316b1463597b265c3aa92a44dfe7abbe3c19 Cr-Commit-Position: refs/heads/master@{#30414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M src/ppc/builtins-ppc.cc View 5 chunks +18 lines, -16 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-26 21:38:13 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-08-27 13:38:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309113003/1
5 years, 3 months ago (2015-08-27 13:42:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 14:23:27 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 14:23:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f481316b1463597b265c3aa92a44dfe7abbe3c19
Cr-Commit-Position: refs/heads/master@{#30414}

Powered by Google App Engine
This is Rietveld 408576698