Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1309103002: Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, kalyank, piman+watch_chromium.org, media-router+watch_chromium.org, mcasas+watch_chromium.org, yurys, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), wjia+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 (patchset #1 id:1 of https://codereview.chromium.org/1310103002/ ) Reason for revert: Looks like this breaks mojo_system_unittests on Android... http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=29595 Original issue's description: > Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 > > Re-land. Previously conflicted with another CL that landed > just before the roll. > > BUG=None > TBR=jam@chromium.org,ben@chromium.org > TBR=mfoltz@chromium.org > TBR=mek@chromium.org > TBR=xhwang@chromium.org > TBR=shess@chromium.org > > Committed: https://crrev.com/0bfe154baad9ddfb1f0c6ecc7cace36e8f430e75 > Cr-Commit-Position: refs/heads/master@{#344994} TBR=ben@chromium.org,jam@chromium.org,mek@chromium.org,mfoltz@chromium.org,shess@chromium.org,xhwang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/bd9bf5a43f904f59ebac4f0982a3e3ddddf61e4b Cr-Commit-Position: refs/heads/master@{#344996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1068 lines, -2505 lines) Patch
D build/module_args/dart.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/devtools_service/devtools_http_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/files_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/document_resource_waiter.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_frame.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/web_socket_handle_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/child/navigator_connect/service_port_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/usb/web_usb_client_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M device/serial/data_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/data_sink_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/data_source_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/mojo/stash_backend_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/public/cpp/application_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/public/cpp/lib/service_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/tools/rev_sdk.py View 1 chunk +0 lines, -1 line 0 comments Download
M sql/mojo/sql_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/mojo_edk.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/mojo/mojo_edk_system_impl.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 5 chunks +0 lines, -23 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 5 chunks +15 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/js_to_cpp_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/mojo_edk.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.h View 3 chunks +17 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.cc View 16 chunks +15 lines, -18 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint.h View 5 chunks +19 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.h View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager.h View 4 chunks +9 lines, -29 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager_unittest.cc View 10 chunks +26 lines, -41 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core_test_base.h View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core_test_base.cc View 10 chunks +45 lines, -45 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_consumer_dispatcher.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_consumer_dispatcher.cc View 8 chunks +10 lines, -15 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_producer_dispatcher.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_producer_dispatcher.cc View 8 chunks +10 lines, -15 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/dispatcher.h View 8 chunks +50 lines, -72 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/dispatcher.cc View 31 chunks +37 lines, -39 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/endpoint_relayer.h View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/endpoint_relayer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/incoming_endpoint.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/incoming_endpoint.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/ipc_support.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.h View 5 chunks +16 lines, -17 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 16 chunks +31 lines, -78 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_in_transit.h View 1 chunk +3 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_dispatcher.h View 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_dispatcher.cc View 6 chunks +10 lines, -10 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/mutex.h View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/mutex.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/mutex_unittest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher.h View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/raw_channel_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/shared_buffer_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.h View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.cc View 11 chunks +49 lines, -66 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/test_channel_endpoint_client.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/test_channel_endpoint_client.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/edk/system/thread_annotations.h View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/thread_annotations_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/waiter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/c/gpu/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/binding.h View 3 chunks +16 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/callback.h View 4 chunks +2 lines, -21 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/interface_impl.h View 1 chunk +178 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +14 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h View 1 chunk +6 lines, -9 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/message_queue.h View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/message_queue.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +0 lines, -24 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/binding_unittest.cc View 8 chunks +27 lines, -225 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/bindings/tests/bindings_perftest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/callback_unittest.cc View 3 chunks +2 lines, -70 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/connector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/bindings/tests/message_queue.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/bindings/tests/message_queue.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/request_response_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/router_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/dart/.analysis_options View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/CHANGELOG.md View 1 chunk +0 lines, -20 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/lib/io.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/dart/rules.gni View 5 chunks +3 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/interfaces/bindings/tests/ping_service.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_unions.mojom View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 7 chunks +24 lines, -131 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/descriptor.py View 3 chunks +2 lines, -53 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/reflection.py View 1 chunk +0 lines, -97 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/serialization.py View 2 chunks +1 line, -90 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/enum_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +10 lines, -16 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py View 5 chunks +7 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module_macros.tmpl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_pkg.py View 5 chunks +5 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598
5 years, 4 months ago (2015-08-23 01:40:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309103002/1
5 years, 4 months ago (2015-08-23 01:41:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-23 01:42:15 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-23 01:43:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd9bf5a43f904f59ebac4f0982a3e3ddddf61e4b
Cr-Commit-Position: refs/heads/master@{#344996}

Powered by Google App Engine
This is Rietveld 408576698