Source/core/dom/ContainerNode.cpp - Issue 1309083002: Accurately update Document node counts on disposing shadow roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 1309083002: Accurately update Document node counts on disposing shadow roots. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Adjust document node count in addChildNodesToDeletionQueue() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index 90fb8b95765b2b14cd01fa75d3bc6bcc2658450c..5a44e55d67cbe96d456b2c3e4279929563e6b35a 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -513,6 +513,9 @@ void ContainerNode::addChildNodesToDeletionQueue(Node*& head, Node*& tail, Conta

next->setPreviousSibling(nullptr);

if (!n->refCount()) {

+ if (n->inDocument())

+ container.document().decrementNodeCount();

#if ENABLE(SECURITY_ASSERT)

n->m_deletionHasBegun = true;

#endif

« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | no next file with comments »