Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309063006: Fix vectorized icon for PPAPI broker website setting icon (Closed)

Created:
5 years, 3 months ago by Evan Stade
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix vectorized icon for PPAPI broker website setting icon [!] instead of [x] badge BUG=505953 Committed: https://crrev.com/c43ad6b008455d58e6c830e03bf14d0f5b30f144 Cr-Commit-Position: refs/heads/master@{#347848}

Patch Set 1 #

Patch Set 2 : GN and spurious ; #

Patch Set 3 : oops wrong CL #

Patch Set 4 : git add is a good idea #

Patch Set 5 : docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M chrome/browser/ui/content_settings/content_setting_image_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.cc View 1 2 3 4 4 chunks +19 lines, -8 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + ui/gfx/vector_icons/warning_badge.icon View 1 2 3 1 chunk +9 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309063006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309063006/40001
5 years, 3 months ago (2015-09-08 17:56:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309063006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309063006/60001
5 years, 3 months ago (2015-09-08 17:59:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 19:10:57 UTC) #6
Evan Stade
5 years, 3 months ago (2015-09-08 23:51:59 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309063006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309063006/80001
5 years, 3 months ago (2015-09-08 23:52:25 UTC) #10
sky
LGTM
5 years, 3 months ago (2015-09-09 00:02:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309063006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309063006/80001
5 years, 3 months ago (2015-09-09 00:06:47 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-09 00:38:19 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 00:39:12 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/c43ad6b008455d58e6c830e03bf14d0f5b30f144
Cr-Commit-Position: refs/heads/master@{#347848}

Powered by Google App Engine
This is Rietveld 408576698